Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simple mirror support #6503

Merged
merged 2 commits into from
Feb 26, 2019
Merged

Conversation

justinsb
Copy link
Member

We recognize our primary location via string-matching, and we then
have a hard-coded list of mirrors for that location.

Didn't prove easy to make this much better, but we can hopefully do so
iteratively (e.g. fetch mirrors via URL)

We recognize our primary location via string-matching, and we then
have a hard-coded list of mirrors for that location.

Didn't prove easy to make this much better, but we can hopefully do so
iteratively (e.g. fetch mirrors via URL)
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 20, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 20, 2019
@justinsb
Copy link
Member Author

Two things of note:

  • nodeup will try all the mirrors, and so the fact that not all the artifacts are present for the older github releases won't matter (one http 404). I'm not planning on backporting, as that would mean going back and adding binaries to the old releases.
  • the current mirrors won't do much - github and an S3 bucket, but we're hopefully getting a CNCF bucket soon. Maybe by the 1.12 release, but then we can just throw it onto the pile!

@zetaab
Copy link
Member

zetaab commented Feb 26, 2019

/lgtm

I am thinking could we use cloudfront in front of normal s3 bucket? cloudfront will cache things to different regions. Maybe that is something that we could think of doing when we have cncf bucket?

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 26, 2019
@k8s-ci-robot k8s-ci-robot merged commit b922aa5 into kubernetes:master Feb 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants