Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spread instances equally to all AZs #6534

Merged
merged 1 commit into from
Feb 28, 2019
Merged

Conversation

zetaab
Copy link
Member

@zetaab zetaab commented Feb 26, 2019

fixes issue #6533

Before:
screenshot 2019-02-26 at 9 25 09

After:
screenshot 2019-02-26 at 10 18 08

/sig openstack

/cc @drekle please review

@k8s-ci-robot k8s-ci-robot requested a review from drekle February 26, 2019 08:21
@k8s-ci-robot k8s-ci-robot added the area/provider/openstack Issues or PRs related to openstack provider label Feb 26, 2019
@k8s-ci-robot
Copy link
Contributor

@zetaab: GitHub didn't allow me to request PR reviews from the following users: please, review.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

fixes issue #6533

Before:
screenshot 2019-02-26 at 9 25 09

After:
screenshot 2019-02-26 at 10 18 08

/sig openstack

/cc @drekle please review

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 26, 2019
@zetaab zetaab force-pushed the spread branch 2 times, most recently from f2cf5e5 to ab21a63 Compare February 27, 2019 11:56
@k8s-ci-robot k8s-ci-robot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 27, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zetaab

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 27, 2019
@zetaab
Copy link
Member Author

zetaab commented Feb 27, 2019

@drekle can you check now again? Of course we could add zone information to ig.Spec.Zones (its only added in case of GCP). However, in case of openstack this information is already in place in subnets.

Copy link
Contributor

@drekle drekle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 28, 2019
@k8s-ci-robot k8s-ci-robot merged commit 01cdc4a into kubernetes:master Feb 28, 2019
@zetaab zetaab deleted the spread branch September 21, 2019 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/openstack Issues or PRs related to openstack provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants