-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
spread instances equally to all AZs #6534
Conversation
@zetaab: GitHub didn't allow me to request PR reviews from the following users: please, review. Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
f2cf5e5
to
ab21a63
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zetaab The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@drekle can you check now again? Of course we could add zone information to ig.Spec.Zones (its only added in case of GCP). However, in case of openstack this information is already in place in subnets. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
fixes issue #6533
Before:
![screenshot 2019-02-26 at 9 25 09](https://user-images.githubusercontent.com/22482503/53397602-348a0a80-39b0-11e9-99e0-5ea2f6118666.png)
After:
![screenshot 2019-02-26 at 10 18 08](https://user-images.githubusercontent.com/22482503/53397611-38b62800-39b0-11e9-8525-441653de189e.png)
/sig openstack
/cc @drekle please review