Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If using etcd-backup and TLS is enabled, pass relevant options #6562

Merged
merged 1 commit into from
Mar 25, 2019
Merged

If using etcd-backup and TLS is enabled, pass relevant options #6562

merged 1 commit into from
Mar 25, 2019

Conversation

KashifSaadat
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 1, 2019
@KashifSaadat
Copy link
Contributor Author

/assign @justinsb

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 1, 2019
@KashifSaadat KashifSaadat mentioned this pull request Mar 1, 2019
Merged
@justinsb justinsb added this to the 1.12 milestone Mar 14, 2019
@justinsb
Copy link
Member

Thanks @KashifSaadat

I merged the other PR upstream, will send another PR to bump the version here.

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 25, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb, KashifSaadat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [KashifSaadat,justinsb]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@justinsb
Copy link
Member

@KashifSaadat is it OK to remove the WIP / hold? I'd like to get this into 1.12-alpha.1, as it feels like a bugfix...

justinsb added a commit to justinsb/kops that referenced this pull request Mar 25, 2019
@justinsb
Bump etcd-manager / etcd-backup to 3.0.20190325
2944599 
Picking up kopeio/etcd-manager#192, for kubernetes#6562
@justinsb justinsb mentioned this pull request Mar 25, 2019
Merged
@KashifSaadat KashifSaadat changed the title WIP: If using etcd-backup and TLS is enabled, pass relevant options If using etcd-backup and TLS is enabled, pass relevant options Mar 25, 2019
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 25, 2019
@KashifSaadat
Copy link
Contributor Author

Awesome thanks @justinsb ! Just removed the WIP :)

@k8s-ci-robot k8s-ci-robot merged commit 269a6f6 into kubernetes:master Mar 25, 2019
@KashifSaadat KashifSaadat deleted the etcd-backup-tls branch March 25, 2019 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rdrgmnzs rdrgmnzs Awaiting requested review from rdrgmnzs

@robinpercy robinpercy Awaiting requested review from robinpercy

Assignees

@justinsb justinsb

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.12
Development

Successfully merging this pull request may close these issues.
3 participants
@KashifSaadat @justinsb @k8s-ci-robot