-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding installation guidelines for Windows #6594
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Hi @EchoDelta. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@EchoDelta can you please sign the CLA? As someone else already figured out having a Linux Foundation ID is not enough and it needs to be signed to the email address you used to create the commits with, not the one you used to sign up to GitHub with. |
@chrisz100 Should have been signed now :) |
Great, thanks! /lgtm |
I'm getting old... |
/retest |
Thanks for this @EchoDelta! Is there a more windowsy way to do this via script? Based on my knowledge, we can't guarantee they have curl or something similiar so I'll approve this for now since it's definitely an improvement! Thanks! /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: EchoDelta, mikesplain The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@mikesplain A good solution might be to publish to chocolatey so it can be installed from there. Chocolatey is not a native package manager for Windows, but is like Homebrew for Mac OS and is widely used. An install would then be something like:
I could probably also write a Powershell script for installation, but it is probably just as easy to use the written instructions. |
No description provided.