Delete the function keyword to prevent shellcheck from failing

[xichengliudui]

No description provided.

[xichengliudui]

/assign @justinsb

[justinsb]

Thanks for thinking about this! I ran shellcheck and got a lot of warnings about lack of quoting

e.g.

In hack/make-gendocs.sh line 52:
cp ${WORK_DIR}/go/bin/client-gen ${GOPATH}/bin/
   ^-- SC2086: Double quote to prevent globbing and word splitting.
                                 ^-- SC2086: Double quote to prevent globbing and word splitting.

But I didn't see any errors complaining about the use of function - and I would have thought that using function was correct.

What error are you getting from shellcheck?

[xichengliudui]

@justinsb Is there a tool for retrieving scripts in kop? The function keyword error I encountered in k8s repo looks like this:

function cleanup {
^-- SC2113: 'function' keyword is non-standard. Use 'foo()' instead of 'function foo'.
Ref: https://www.shellcheck.net/wiki/SC2113 -- 'function' keyword is non-standar...

If you don't need this pr I can turn it off.

[xichengliudui]

Also, if kop has tools for retrieving scripts, can I fix them?

[xichengliudui]

here.

[xichengliudui]

/assign @justinsb

[xichengliudui]

/assign @justinsb

[justinsb]

I appreciate the change, so let's merge it. Would be great to get shellcheck actually working against our repo. How do you run shellcheck?

/approve
/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb, xichengliudui

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [justinsb]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment