Subnet Update Consistency #6941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
area/provider/openstack
drekle
commented
May 10, 2019
| @@ -60,6 +60,7 @@ func (b *NetworkModelBuilder) Build(c *fi.ModelBuilderContext) error { | |||
| Name: s(subnetName), | |||
| Network: b.LinkToNetwork(), | |||
| CIDR: s(sp.CIDR), | |||
| DNSServers: make([]*string, 0), | |||
There was a problem hiding this comment.
The result of find had compared a nil object to an empty slice.
k8s-ci-robot
added
lgtm
|
/approve cancel can you @drekle fix gofmt things, file pkg/model/openstackmodel/network.go fails in gofmt |
k8s-ci-robot
removed
the
approved
Executing gofmt
drekle
force-pushed
the
openstack_subnet_member_comparison
branch
from
43f2250 to
59fb887
Compare
k8s-ci-robot
added
size/S
|
/approve |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: drekle, zetaab The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
This was referenced May 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this PR is to resolve some errors which can be thrown after updating some already deployed subnet objects. Because the expected struct is checked instead of the changes struct an update may fail after resources have already been deployed.
/sig openstack