Flatcar support #7084

mazzy89 · 2019-05-31T09:37:00Z

Recognize Flatcar (https://www.flatcar-linux.org/)

Flatcar is a friendly-fork of CoreOS.

It is very similar to CoreOS in terms of configuring it. However, I've decided anyway to treat like a different distribution and create different if-else branches.

k8s-ci-robot · 2019-05-31T09:37:01Z

Welcome @mazzy89!

It looks like this is your first PR to kubernetes/kops 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kops has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2019-05-31T09:37:04Z

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

k8s-ci-robot · 2019-05-31T09:37:09Z

Hi @mazzy89. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

mazzy89 · 2019-05-31T10:16:47Z

I've signed it

Signed-off-by: Salvatore Mazzarino <[email protected]>

mazzy89 · 2019-05-31T12:00:07Z

/assign @justinsb

mazzy89 · 2019-05-31T12:48:56Z

nodeup/pkg/model/kubelet.go

+	if b.Distribution == distros.DistributionFlatcar {
+		// Flatcar does not ship with conntrack.  Install our own (statically linked) version
+		// TODO: Extract to common function?
+		for _, binary := range []string{"conntrack"} {


I've checked and I've found out that Flatcar is shipped with socat so it is not necessary to install it.

That is really good news - the omission of socat was so surprising!

chrisz100 · 2019-06-04T08:14:47Z

/ok-to-test
/lgtm

mazzy89 · 2019-06-08T11:21:43Z

Thank you @chrisz100. Ready to be merged.

rifelpet · 2019-06-11T23:23:04Z

Can we include a section in the documentation for Flatcar?

https://github.com/kubernetes/kops/blob/master/docs/images.md

mazzy89 · 2019-06-12T07:30:06Z

Yes sure. I will

Signed-off-by: Salvatore Mazzarino <[email protected]>

mazzy89 · 2019-06-13T16:58:15Z

Added a section in the doc

mazzy89 · 2019-06-13T19:01:59Z

/retest

mazzy89 · 2019-06-17T18:20:05Z

/assign @rifelpet

justinsb · 2019-06-20T12:36:07Z

nodeup/pkg/distros/distribution.go

@@ -52,6 +53,8 @@ func (d Distribution) BuildTags() []string {
 		t = []string{"_rhel7"}
 	case DistributionCoreOS:
 		t = []string{"_coreos"}
+	case DistributionFlatcar:
+		t = []string{"_flatcar"}


Just FYI we hopefully aren't using these tags any more. But no problem with leaving this in for now and removing once we confirm we're not using tags :-)

justinsb · 2019-06-20T12:37:45Z

nodeup/pkg/model/kubelet.go

+	if b.Distribution == distros.DistributionFlatcar {
+		// Flatcar does not ship with conntrack.  Install our own (statically linked) version
+		// TODO: Extract to common function?
+		for _, binary := range []string{"conntrack"} {


That is really good news - the omission of socat was so surprising!

justinsb · 2019-06-20T12:38:59Z

Thanks @mazzy89 - looks good. I do wonder if we should fold some of the very similar code, but let's run with it and see how it evolves!

/approve
/lgtm

k8s-ci-robot · 2019-06-20T12:39:12Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb, mazzy89

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [justinsb]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot · 2019-06-20T13:46:05Z

@mazzy89: The following test failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
pull-kops-e2e-kubernetes-aws	`5fe525a`	link	`/test pull-kops-e2e-kubernetes-aws`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Cherry pick of #7084 onto release-1.14

k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label May 31, 2019

k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 31, 2019

k8s-ci-robot requested review from rdrgmnzs and robinpercy May 31, 2019 09:37

mazzy89 force-pushed the flatcar_support branch 3 times, most recently from 1e60e63 to 75a7e6c Compare May 31, 2019 09:58

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels May 31, 2019

Flatcar support

c7381f9

Signed-off-by: Salvatore Mazzarino <[email protected]>

mazzy89 force-pushed the flatcar_support branch from 75a7e6c to c7381f9 Compare May 31, 2019 10:20

k8s-ci-robot assigned justinsb May 31, 2019

mazzy89 commented May 31, 2019

View reviewed changes

k8s-ci-robot assigned chrisz100 Jun 4, 2019

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 4, 2019

Add docs/images.md

5fe525a

Signed-off-by: Salvatore Mazzarino <[email protected]>

k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 13, 2019

k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 13, 2019

k8s-ci-robot assigned rifelpet Jun 17, 2019

justinsb reviewed Jun 20, 2019

View reviewed changes

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 20, 2019

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 20, 2019

k8s-ci-robot merged commit 1798ddf into kubernetes:master Jun 20, 2019

justinsb mentioned this pull request Jul 19, 2019

Cherry pick of #7084 onto release-1.14 #7266

Merged

k8s-ci-robot added a commit that referenced this pull request Jul 19, 2019

Merge pull request #7266 from justinsb/cherrypick_7084_release-1.14

8e4bfb5

Cherry pick of #7084 onto release-1.14

mazzy89 deleted the flatcar_support branch September 10, 2019 07:54

jeckhart mentioned this pull request Jul 15, 2020

Support distribution Flatcar #7075

Closed

jkroepke mentioned this pull request Apr 11, 2022

Support Flatcar Linux aws/amazon-ssm-agent#442

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Flatcar support #7084

Flatcar support #7084

mazzy89 commented May 31, 2019 •

edited

Loading

k8s-ci-robot commented May 31, 2019

k8s-ci-robot commented May 31, 2019

k8s-ci-robot commented May 31, 2019

mazzy89 commented May 31, 2019

mazzy89 commented May 31, 2019

mazzy89 May 31, 2019

justinsb Jun 20, 2019

chrisz100 commented Jun 4, 2019

mazzy89 commented Jun 8, 2019

rifelpet commented Jun 11, 2019

mazzy89 commented Jun 12, 2019

mazzy89 commented Jun 13, 2019

mazzy89 commented Jun 13, 2019

mazzy89 commented Jun 17, 2019

justinsb Jun 20, 2019

justinsb Jun 20, 2019

justinsb commented Jun 20, 2019

k8s-ci-robot commented Jun 20, 2019

k8s-ci-robot commented Jun 20, 2019

Flatcar support #7084

Flatcar support #7084

Conversation

mazzy89 commented May 31, 2019 • edited Loading

k8s-ci-robot commented May 31, 2019

k8s-ci-robot commented May 31, 2019

k8s-ci-robot commented May 31, 2019

mazzy89 commented May 31, 2019

mazzy89 commented May 31, 2019

mazzy89 May 31, 2019

Choose a reason for hiding this comment

justinsb Jun 20, 2019

Choose a reason for hiding this comment

chrisz100 commented Jun 4, 2019

mazzy89 commented Jun 8, 2019

rifelpet commented Jun 11, 2019

mazzy89 commented Jun 12, 2019

mazzy89 commented Jun 13, 2019

mazzy89 commented Jun 13, 2019

mazzy89 commented Jun 17, 2019

justinsb Jun 20, 2019

Choose a reason for hiding this comment

justinsb Jun 20, 2019

Choose a reason for hiding this comment

justinsb commented Jun 20, 2019

k8s-ci-robot commented Jun 20, 2019

k8s-ci-robot commented Jun 20, 2019

mazzy89 commented May 31, 2019 •

edited

Loading