[Unit Tests] Added unit test for kube proxy builder

[srikiz]

Adding unit tests for additional code coverage.
This should include test for nodeup/pkg/model/kube_proxy.go.

I created a new file kube_proxy_test.go that performs few basic checks on how the kube_proxy pod is built.

[k8s-ci-robot]

Hi @srikiz. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[srikiz]

/assign @justinsb

[mikesplain]

Awesome! Always love more tests, thanks @srikiz! Lets get this testing!

/ok-to-test

[srikiz]

@mikesplain - Thanks, while I wrote this unit test, I didn't actually understand why we need this specific flag for kubeproxy.
--oom-score-adj=-998
Any idea where to look this out for?

[srikiz]

/retest

[rdrgmnzs]

@srikiz this is a good explanation of why that flag is set kubernetes/kubernetes#51083 (comment)

[srikiz]

@srikiz this is a good explanation of why that flag is set kubernetes/kubernetes#51083 (comment)

Thanks, this sounds good !

[srikiz]

@rdrgmnzs @mikesplain - please approve if you are Ok.

[justinsb]

What we've done elsewhere is to serialize it to yaml and then string-compare with the expected output. It tends to make the test a little easier to write, and means we have the output explicitly in the tree which can be pretty handy!

But ... happy to try this approach!

[srikiz]

sure, thanks @justinsb - I'll keep a note of it for other unit tests.

[justinsb]

Thanks @srikiz - our yaml "golden output" test approach is also worth considering, but having more test coverage is very welcome - thank you!

/approve
/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb, srikiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [justinsb]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment