Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rdrgmnzs to the approvers list in OWNERS #7154

Merged
merged 1 commit into from
Jun 20, 2019

Conversation

rdrgmnzs
Copy link
Contributor

Add rdrgmnzs to the approvers list in OWNERS

Add rdrgmnzs to the approvers list in OWNERS
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 17, 2019
@mikesplain
Copy link
Contributor

This is a great addition! @rdrgmnzs has been a fantastic contributor and reviewer for a long time. This is very well deserved and I think would be a valuable asset to the approvers team.

I'm going to lgtm this but also mark as hold for others to review prior to merging. Thanks @rdrgmnzs!

/lgtm
/hold

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Jun 18, 2019
@mikesplain
Copy link
Contributor

Also... retest lol
/retest

@justinsb
Copy link
Member

Totally agree with this!

/approve
/lgtm
/unhold

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb, rdrgmnzs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 20, 2019
@justinsb
Copy link
Member

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 20, 2019
@k8s-ci-robot k8s-ci-robot merged commit b72a8e7 into kubernetes:master Jun 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants