Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add c5.12xlarge, c5.24xlarge, c5.metal, i3en.metal #7166

Merged
merged 1 commit into from
Jun 20, 2019
Merged

add c5.12xlarge, c5.24xlarge, c5.metal, i3en.metal #7166

merged 1 commit into from
Jun 20, 2019

Conversation

rekcah78
Copy link
Contributor

update instances with make update-machine-types

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 19, 2019
@rekcah78
Copy link
Contributor Author

/assign @mikesplain

mikesplain
mikesplain suggested changes Jun 19, 2019
View reviewed changes
Copy link
Contributor

@mikesplain mikesplain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @rekcah78!

Looking forward to getting this in to 1.13

upup/pkg/fi/cloudup/awsup/machine_types.go Outdated Show resolved Hide resolved
@rekcah78 rekcah78 changed the title add c5.12xlarge, c5.24xlarge, c5.metal add c5.12xlarge, c5.24xlarge, c5.metal, i3en.metal Jun 20, 2019
@justinsb
Copy link
Member

Thanks for filling in the ones that are known. We can go with this as-is I believe, and then when AWS publishes the specs for i3en.metal we can fill those in!

/approve
/lgtm
/retest

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 20, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb, rekcah78

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 20, 2019
@k8s-ci-robot k8s-ci-robot merged commit 00edef8 into kubernetes:master Jun 20, 2019
@rekcah78 rekcah78 deleted the add_new_c5_instances branch June 21, 2019 00:58
@rekcah78
Copy link
Contributor Author

@mikesplain I have to open a PR for merge in 1.13 and 1.14?

This was referenced Jun 28, 2019
Merged
Merged
@mikesplain
Copy link
Contributor

@rekcah78 Done 😄
Feel free to /lgtm those cherry picks if they look good to you!

k8s-ci-robot added a commit that referenced this pull request Jun 28, 2019
@k8s-ci-robot
Merge pull request #7198 from mikesplain/automated-cherry-pick-of-#71…
f5645d2 
…66-origin-release-1.13

Automated cherry pick of #7166: update instances list with make update-machine-types
k8s-ci-robot added a commit that referenced this pull request Jun 28, 2019
@k8s-ci-robot
Merge pull request #7199 from mikesplain/automated-cherry-pick-of-#71…
bafd3c7 
…66-origin-release-1.14

Automated cherry pick of #7166: update instances list with make update-machine-types
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikesplain mikesplain mikesplain requested changes

@rdrgmnzs rdrgmnzs Awaiting requested review from rdrgmnzs

@robinpercy robinpercy Awaiting requested review from robinpercy

Assignees

@justinsb justinsb

@mikesplain mikesplain

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rekcah78 @justinsb @k8s-ci-robot @mikesplain