-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GCE tutorial markdown formatting #7188
Conversation
Hi! First of all I'd like to thank you for making this! I'm eager to try it out o/ The current `master` version of the document contains a few formatting issues that makes it hard to read. The proposed changes attempt to make formatting better to read and concise. Rendering the Github markdown will provide better "before and after" view of the changes.
Welcome @flaviamissi! |
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Hi @flaviamissi. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Thanks - this does look better! Out of interest, why do you use the indent style instead of the triple backticks? I didn't know you could do that! Are you able to sign the CLA? It's a bit of a pain the first time, but once you've done so it should be valid across all the kubernetes projects? |
Ah - apparently my commenting woke up the CLA bot. So ignore that :-) |
Thanks @flaviamissi ... I do wonder about indent vs backticks and whether there's a reason to go one way or the other, but thank for fixing! /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: flaviamissi, justinsb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hey @justinsb, sorry for the long delay!
I have no strong reason to use one or the other. The background for switching to indents in this specific case was that the triple backticks got messy, so it seemed simpler to use the indentation here. Hope the choice wasn't confusing! And thanks for getting the patch in! 💪 |
Hi! First of all I'd like to thank you for making this! I'm eager to try it out o/
The current
master
version of the document contains a few formatting issues that makes it hard to read. The proposed changes attempt to make formatting better to read and more concise. Rendering the Github markdown will provide better "before and after" view of the changes.