Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update instances list with make update-machine-types #7195

Merged
merged 1 commit into from
Jul 9, 2019
Merged

update instances list with make update-machine-types #7195

merged 1 commit into from
Jul 9, 2019

Conversation

rekcah78
Copy link
Contributor

adding :
m5.8xlarge
m5.16xlarge

m5a.8xlarge
m5a.16xlarge

m5d.8xlarge
m5d.16xlarge

r5.8xlarge
r5.16xlarge

r5a.8xlarge
r5a.16xlarge

r5d.8xlarge
r5d.16xlarge

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 27, 2019
Copy link
Contributor

@mikesplain mikesplain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Thanks @rekcah78!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 27, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mikesplain, rekcah78

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 27, 2019
@mikesplain
Copy link
Contributor

I'll open cherry-picks for the upcoming releases as well.

k8s-ci-robot added a commit that referenced this pull request Jun 28, 2019
…95-origin-release-1.13

Automated cherry pick of #7195: update instances list with make update-machine-types
k8s-ci-robot added a commit that referenced this pull request Jun 28, 2019
…95-origin-release-1.14

Automated cherry pick of #7195: update instances list with make update-machine-types
@rifelpet
Copy link
Member

/test pull-kops-e2e-kubernetes-aws

@rekcah78
Copy link
Contributor Author

/retest

2 similar comments
@rekcah78
Copy link
Contributor Author

rekcah78 commented Jul 1, 2019

/retest

@mikesplain
Copy link
Contributor

/retest

@rekcah78
Copy link
Contributor Author

rekcah78 commented Jul 3, 2019

@mikesplain do you think the test failure is due to my PR or the e2e platform ?

@zetaab
Copy link
Member

zetaab commented Jul 9, 2019

/test pull-kops-e2e-kubernetes-aws

@k8s-ci-robot k8s-ci-robot merged commit 21b5e3b into kubernetes:master Jul 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants