Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make an actual deep-copy of the state #7219

Merged
merged 1 commit into from
Jul 10, 2019
Merged

Make an actual deep-copy of the state #7219

merged 1 commit into from
Jul 10, 2019

Conversation

jacksontj
Copy link
Contributor

Before this patch this was creating a shallow copy, as the KVState was
copied but the underlying map (Records) wasn't.

Fixes #7134

Go playground showing the issue with the previous copy mechanism: https://play.golang.org/p/0-NAWVpbR7s

@k8s-ci-robot k8s-ci-robot added do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 3, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @jacksontj. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 3, 2019
@jacksontj jacksontj mentioned this pull request Jul 3, 2019
Closed
@zetaab
Copy link
Member

zetaab commented Jul 3, 2019

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 3, 2019
@jacksontj
Copy link
Contributor Author

Unfortunately all the e2e tests are still blocked on kubernetes/kubernetes#79305 -- it made an error fatal which every test run hits (details in slack )

@jacksontj
Make an actual deep-copy of the state
bf8efa8 
Before this patch this was creating a shallow copy, as the KVState was
copied but the underlying map (Records) wasn't.

Related to kubernetes#7134
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Jul 9, 2019
@justinsb
Copy link
Member

Thanks for tracking down and fixing @jacksontj ... I think we finally got the e2es working again, following @zetaab 's suggestion of testing with 1.15 (and I have a fix for the underlying issue in 1.16 also).

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 10, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jacksontj, justinsb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 10, 2019
@k8s-ci-robot k8s-ci-robot merged commit a8b0e1b into kubernetes:master Jul 10, 2019
This was referenced Jul 10, 2019
Merged
Merged
Merged
@jacksontj jacksontj deleted the issue_7134 branch July 11, 2019 19:01
k8s-ci-robot added a commit that referenced this pull request Jul 12, 2019
@k8s-ci-robot
Merge pull request #7230 from jacksontj/automated-cherry-pick-of-#721…
d5d809b 
…9-upstream-release-1.13

Automated cherry pick of #7219: Make an actual deep-copy of the state
k8s-ci-robot added a commit that referenced this pull request Jul 12, 2019
@k8s-ci-robot
Merge pull request #7231 from jacksontj/automated-cherry-pick-of-#721…
c329f94 
…9-upstream-release-1.14

Automated cherry pick of #7219: Make an actual deep-copy of the state
k8s-ci-robot added a commit that referenced this pull request Jul 12, 2019
@k8s-ci-robot
Merge pull request #7235 from jacksontj/automated-cherry-pick-of-#721…
302ffaa 
…9-upstream-release-1.12

Automated cherry pick of #7219: Make an actual deep-copy of the state
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrislovecnm chrislovecnm Awaiting requested review from chrislovecnm

@rdrgmnzs rdrgmnzs Awaiting requested review from rdrgmnzs

Assignees

@justinsb justinsb

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

concurrent map iteration and map write in protokube gossip mesh (repeat of #6635 )
4 participants
@jacksontj @k8s-ci-robot @zetaab @justinsb