-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add OpenStack etcd-manager support #7395
add OpenStack etcd-manager support #7395
Conversation
hold until kopeio/etcd-manager#245 is merged |
e21d81a
to
0b9a5fe
Compare
/hold cancel |
I just uploaded etcd-manager 3.0.20190816 also, with the PRs for OpenStack & DigitalOcean incorporated. |
great! |
@justinsb I updated the etcd-manager in this PR as well. No need to do separate PR |
Thanks @zetaab /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justinsb, zetaab The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@@ -442,7 +442,7 @@ func (b *FirewallModelBuilder) addProtokubeRules(c *fi.ModelBuilderContext, sgMa | |||
Direction: s(string(rules.DirIngress)), | |||
Protocol: s(string(rules.ProtocolTCP)), | |||
EtherType: s(string(rules.EtherType4)), | |||
PortRangeMin: i(3998), | |||
PortRangeMin: i(3994), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this is for etcd manager can we add a comment? I've been trying to do this with self documenting code and the method names, however I think its probably fine here with a comment as its just taking some of the work out of protokube.
Also not sure if there is a sane way of checking that we are using etcd manager and only opening the port in the event that the provider is not Legacy
.
adds openstack support for etcd-manager, no need to use legacy anymore.
cc @drekle
/hold
lets wait that openstack support for etcd-manager is added