Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add OpenStack etcd-manager support #7395

Merged
merged 5 commits into from
Aug 16, 2019

Conversation

zetaab
Copy link
Member

@zetaab zetaab commented Aug 12, 2019

adds openstack support for etcd-manager, no need to use legacy anymore.

cc @drekle

/hold

lets wait that openstack support for etcd-manager is added

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 12, 2019
@zetaab
Copy link
Member Author

zetaab commented Aug 13, 2019

hold until kopeio/etcd-manager#245 is merged

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 13, 2019
@zetaab zetaab force-pushed the openstack/etcd-manager branch from e21d81a to 0b9a5fe Compare August 13, 2019 13:49
@zetaab
Copy link
Member Author

zetaab commented Aug 16, 2019

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 16, 2019
@justinsb
Copy link
Member

I just uploaded etcd-manager 3.0.20190816 also, with the PRs for OpenStack & DigitalOcean incorporated.

@zetaab
Copy link
Member Author

zetaab commented Aug 16, 2019

great!

@zetaab
Copy link
Member Author

zetaab commented Aug 16, 2019

@justinsb I updated the etcd-manager in this PR as well. No need to do separate PR

@justinsb
Copy link
Member

Thanks @zetaab

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 16, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb, zetaab

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 16, 2019
@@ -442,7 +442,7 @@ func (b *FirewallModelBuilder) addProtokubeRules(c *fi.ModelBuilderContext, sgMa
Direction: s(string(rules.DirIngress)),
Protocol: s(string(rules.ProtocolTCP)),
EtherType: s(string(rules.EtherType4)),
PortRangeMin: i(3998),
PortRangeMin: i(3994),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is for etcd manager can we add a comment? I've been trying to do this with self documenting code and the method names, however I think its probably fine here with a comment as its just taking some of the work out of protokube.

Also not sure if there is a sane way of checking that we are using etcd manager and only opening the port in the event that the provider is not Legacy.

@k8s-ci-robot k8s-ci-robot merged commit 6ea097d into kubernetes:master Aug 16, 2019
@zetaab zetaab deleted the openstack/etcd-manager branch September 21, 2019 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants