Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Amazon VPC CNI plugin to 1.5.4 #7398

Merged
merged 1 commit into from
Oct 11, 2019
Merged

Upgrade Amazon VPC CNI plugin to 1.5.4 #7398

merged 1 commit into from
Oct 11, 2019

Conversation

rifelpet
Copy link
Member

@rifelpet rifelpet commented Aug 12, 2019 •
edited
Loading

This was released recently: https://github.com/aws/amazon-vpc-cni-k8s/releases/tag/v1.5.4

Also properly set the addon versions for older versions of kubernetes.
Older versions of Kubernetes are still using 1.3.3:

kops/upup/models/cloudup/resources/addons/networking.amazon-vpc-routed-eni/k8s-1.10.yaml.template

Line 70 in 8568c64

- image: "{{- or .Networking.AmazonVPC.ImageName "602401143452.dkr.ecr.us-west-2.amazonaws.com/amazon-k8s-cni:1.3.3" }}"

Technically anyone running an older version of kops will have their addon version downgraded even though the manifest itself didnt change. I'm not sure what impact that may have if any.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 12, 2019
@rifelpet
Copy link
Member Author

/test pull-kops-e2e-kubernetes-aws

1 similar comment
@rifelpet
Copy link
Member Author

/test pull-kops-e2e-kubernetes-aws

@rifelpet rifelpet force-pushed the amazon-vpc-cni-153 branch from 82f602f to beea8ab Compare August 17, 2019 13:38
@rifelpet
Copy link
Member Author

/test pull-kops-e2e-kubernetes-aws

@rifelpet
Copy link
Member Author

rifelpet commented Sep 12, 2019 •
edited
Loading

/test pull-kops-verify-gomod

@faheem-nadeem
Copy link

Hi. May be use v1.5.4 as that is also out or even wait for v1.6.0, which will be out soon as that has some important bug fixes for leaked ENIs.

@rifelpet rifelpet force-pushed the amazon-vpc-cni-153 branch from beea8ab to af398ce Compare October 4, 2019 19:52
@rifelpet
Copy link
Member Author

rifelpet commented Oct 4, 2019

Good idea, I updated this to 1.5.4 and if 1.6.0 comes out before this is merged I'll update it again :)

@rifelpet rifelpet changed the title Upgrade Amazon VPC CNI plugin to 1.5.3 Upgrade Amazon VPC CNI plugin to 1.5.4 Oct 4, 2019
@rifelpet
Copy link
Member Author

rifelpet commented Oct 4, 2019

/test pull-kops-verify-gofmt

@mikesplain
Copy link
Contributor

Thanks @rifelpet!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 11, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mikesplain, rifelpet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 11, 2019
@k8s-ci-robot k8s-ci-robot merged commit cc68e42 into kubernetes:master Oct 11, 2019
@justinsb justinsb mentioned this pull request Oct 14, 2019
Merged
k8s-ci-robot added a commit that referenced this pull request Oct 14, 2019
@k8s-ci-robot
Merge pull request #7784 from justinsb/automated-cherry-pick-of-#7398…
e83a0ef 
…-origin-release-1.15

Automated cherry pick of #7398: Upgrade Amazon VPC CNI plugin to 1.5.4
@rifelpet rifelpet deleted the amazon-vpc-cni-153 branch August 6, 2020 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinsb justinsb justinsb left review comments

@granular-ryanbonham granular-ryanbonham Awaiting requested review from granular-ryanbonham

@robinpercy robinpercy Awaiting requested review from robinpercy

Assignees

@mikesplain mikesplain

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rifelpet @faheem-nadeem @mikesplain @k8s-ci-robot @justinsb