Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow configure ip to ip mode in calico #7481

Merged
merged 2 commits into from
Aug 29, 2019
Merged

Allow configure ip to ip mode in calico #7481

merged 2 commits into from
Aug 29, 2019

Conversation

zetaab
Copy link
Member

@zetaab zetaab commented Aug 28, 2019 •
edited
Loading

Currently ip to ip mode is hardcoded to be Always or CrossSubnet. However, ip to ip mode is taking quite big performance hit all the time. That is why we want to disable ip to ip mode in some services. We can see about ~10x increase in network performance if we use never option.

so the network config then is

  networking:
    calico:
      majorVersion: v3
      ipipMode: never

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 28, 2019
@zetaab zetaab force-pushed the feature/calicoiptoip branch from bdcb74d to efcec7f Compare August 28, 2019 17:26
@justinsb
Copy link
Member

#7485 should deal with the travis flakes while pulling from github

@zetaab zetaab changed the title Allow configure ip to ip mode Allow configure ip to ip mode in calico Aug 29, 2019
@zetaab zetaab force-pushed the feature/calicoiptoip branch from df8796b to 72f444b Compare August 29, 2019 17:23
@justinsb
Copy link
Member

Thanks @zetaab - the new field name "speaks to me" more :-)

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 29, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb, zetaab

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 29, 2019
@k8s-ci-robot k8s-ci-robot merged commit 09d38b8 into kubernetes:master Aug 29, 2019
@zetaab zetaab deleted the feature/calicoiptoip branch September 10, 2019 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinsb justinsb justinsb left review comments

@granular-ryanbonham granular-ryanbonham Awaiting requested review from granular-ryanbonham

@robinpercy robinpercy Awaiting requested review from robinpercy

Assignees

@justinsb justinsb

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zetaab @justinsb @k8s-ci-robot