Add event ttl flag

[tioxy]

What type of PR is this?
/kind api-change

What this PR does / why we need it:
Add support for kops to declare event-ttl flag from kube-apiserver

Which issue(s) this PR fixes:
Fixes #7484

Special notes for your reviewer:
Should I remove pkg/apis/kops/types.generated.go from this PR?
This file made this PR longer than it should be 😞
I ran this commented command here

Does this PR introduce a user-facing change?:

Add "event-ttl" flag from kube-apiserver

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

kind: Cluster
spec:
    kubeAPIServer:
        eventTTL: 03h0m0s

[k8s-ci-robot]

Welcome @tioxy!

It looks like this is your first PR to kubernetes/kops 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kops has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @tioxy. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[zetaab]

Could you explain why we have that big changes in pkg/apis/kops/types.generated.go and protokube/pkg/gossip/mesh/mesh.pb.go otherwise this PR looks good

[fejta-bot]

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

[tioxy]

Sure @zetaab

The changes inside pkg/apis/kops/types.generated.go I got by running this command order below (my mistake 😉):

make apimachinery
# This line below is commented inside "apimachinery-codegen" function in Makefile
# There is a comment "codecgen works only if invoked from directory where the file is located"
# I thought it was needed to generated code, so I ran it
cd pkg/apis/kops/ && ~/k8s/bin/codecgen -d 1234 -o types.generated.go instancegroup.go cluster.go
make

The changes inside protokube/pkg/gossip/mesh/mesh.pb.go I honestly do not know. It basically created a multiline import statement instead of multiple unique import statements. Got this mesh.pb.go running the standard order:

make apimachinery
make

I pushed changes to the codegen commit removing unnecessary changes 😁

[zetaab]

/ok-to-test
Now it looks good! Thanks

[rdrgmnzs]

Hi @tioxy this looks good, just requesting 1 change before we look at merging it in.

[tioxy]

Hi @rdrgmnzs, I made some research around time.Duration usage in the current scenario:

It seems that time.Duration has problems with JSON marshaling/unmarshaling using the standard library. This is why the apimachinery project has this wrapper arround time.Duration which is the metav1.Duration.

Currently, our Decode function for codecs is also built on top of apimachinery packages(runtime and serializer). I don't think we'll run into compatibility issues anytime soon 😃

[tioxy]

Fixed merge conflicts

[tioxy]

Added tests for event-ttl flag inside flagbuilder

[tioxy]

/assign @rdrgmnzs

[justinsb]

Thanks @tioxy

/approve
/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb, tioxy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [justinsb]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment