Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to golang 1.12.9 #7499

Merged
merged 1 commit into from
Aug 31, 2019

Conversation

justinsb
Copy link
Member

We particularly want the http fixes in 1.12.8:

https://golang.org/doc/devel/release.html#go1.12.minor

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 31, 2019
@justinsb justinsb force-pushed the update_golang_for_1_15 branch from 8b4f44d to 5a44f20 Compare August 31, 2019 04:29
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 31, 2019
@zetaab
Copy link
Member

zetaab commented Aug 31, 2019

/test pull-kops-e2e-kubernetes-aws

@zetaab
Copy link
Member

zetaab commented Aug 31, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 31, 2019
@rifelpet
Copy link
Member

It looks like protokube is having docker issues now:

Aug 31 07:48:47.726791 ip-172-20-51-72 systemd[1]: Started Kubernetes Protokube Service.
Aug 31 07:48:47.789728 ip-172-20-51-72 docker[2661]: /usr/bin/docker: invalid reference format.
Aug 31 07:48:47.789728 ip-172-20-51-72 docker[2661]: See '/usr/bin/docker run --help'.
Aug 31 07:48:47.791584 ip-172-20-51-72 systemd[1]: protokube.service: Main process exited, code=exited, status=125/n/a
Aug 31 07:48:47.792388 ip-172-20-51-72 systemd[1]: protokube.service: Unit entered failed state.
Aug 31 07:48:47.792433 ip-172-20-51-72 systemd[1]: protokube.service: Failed with result 'exit-code'.
Aug 31 07:48:49.972783 ip-172-20-51-72 systemd[1]: protokube.service: Service hold-off time over, scheduling restart.
Aug 31 07:48:49.973059 ip-172-20-51-72 systemd[1]: Stopped Kubernetes Protokube Service.

@justinsb justinsb force-pushed the update_golang_for_1_15 branch from 5a44f20 to 8daf1c5 Compare August 31, 2019 14:51
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 31, 2019
@rifelpet
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 31, 2019
@k8s-ci-robot k8s-ci-robot merged commit b1413bc into kubernetes:master Aug 31, 2019
justinsb added a commit to justinsb/kops that referenced this pull request Sep 10, 2019
k8s-ci-robot added a commit that referenced this pull request Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants