Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gomod errors #7571

Merged
merged 2 commits into from
Sep 12, 2019
Merged

Fix gomod errors #7571

merged 2 commits into from
Sep 12, 2019

Conversation

mikesplain
Copy link
Contributor

Seems like we're running in to a bit of:

I0912 11:39:57.676] ERROR: go modules are not up to date; please run: go mod tidy
I0912 11:39:57.676] changed files:
I0912 11:39:57.677] ?? .config/
I0912 11:39:57.677] git diff:
W0912 11:39:57.716] Traceback (most recent call last):
W0912 11:39:57.716]   File "/workspace/./test-infra/jenkins/../scenarios/execute.py", line 50, in <module>
W0912 11:39:57.716]     main(ARGS.env, ARGS.cmd + ARGS.args)
W0912 11:39:57.717]   File "/workspace/./test-infra/jenkins/../scenarios/execute.py", line 41, in main
W0912 11:39:57.717]     check(*cmd)
W0912 11:39:57.717]   File "/workspace/./test-infra/jenkins/../scenarios/execute.py", line 30, in check
W0912 11:39:57.717]     subprocess.check_call(cmd)
W0912 11:39:57.717]   File "/usr/lib/python2.7/subprocess.py", line 186, in check_call
W0912 11:39:57.718]     raise CalledProcessError(retcode, cmd)
W0912 11:39:57.718] subprocess.CalledProcessError: Command '('./hack/verify-gomod',)' returned non-zero exit status 1

This is the fix of go mod tidy.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 12, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mikesplain

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 12, 2019
@rifelpet
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 12, 2019
@k8s-ci-robot k8s-ci-robot merged commit 6f629b4 into kubernetes:master Sep 12, 2019
k8s-ci-robot added a commit that referenced this pull request Sep 12, 2019
…71-origin-release-1.15

Automated cherry pick of #7571: Fix go.sum
@mikesplain mikesplain deleted the fix_gomod branch September 13, 2019 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants