Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating master IAM policies. #7580

Merged
merged 1 commit into from
Sep 23, 2019
Merged

Conversation

michalschott
Copy link
Contributor

Should fix #7562

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 13, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @michalschott. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 13, 2019
@michalschott
Copy link
Contributor Author

/assign @mikesplain

@mikesplain
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 13, 2019
@rifelpet
Copy link
Member

I see in the documentation that this is needed to create all 3 types of ELBs but I'm curious why we haven't seen this issue before.

@michalschott Do you know if this is occurring when creating a service of type LoadBalancer, and the cloud controller manager is creating a classic ELB? Is the load balancer creation still succeeding?

@michalschott
Copy link
Contributor Author

@rifelpet It is all working as expected, no single issue with creating ELBs. Just these CloudTrail AccessDenied logs triggering alerts...

@rifelpet
Copy link
Member

ok, that's what I figured. Thanks!
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 13, 2019
@mikesplain
Copy link
Contributor

Thanks @michalschott!

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: michalschott, mikesplain

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 23, 2019
@k8s-ci-robot k8s-ci-robot merged commit e35e9cc into kubernetes:master Sep 23, 2019
k8s-ci-robot added a commit that referenced this pull request Sep 23, 2019
…80-origin-release-1.14

Automated cherry pick of #7580: Updating master IAM policies.
k8s-ci-robot added a commit that referenced this pull request Sep 23, 2019
…80-origin-release-1.15

Automated cherry pick of #7580: Updating master IAM policies.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UnauthorizedAWSAPICalls by master nodes (via CloudTrail)
4 participants