Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use without external router (OpenStack) #7644

Merged
merged 2 commits into from
Sep 21, 2019
Merged

Use without external router (OpenStack) #7644

merged 2 commits into from
Sep 21, 2019

Conversation

zetaab
Copy link
Member

@zetaab zetaab commented Sep 21, 2019

We have environment which do not have any external router so we cannot provisiong floatingips. Instead we will use fixed ips to connect instances.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 21, 2019
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 21, 2019
@zetaab
Copy link
Member Author

zetaab commented Sep 21, 2019

/hold

I need verify this PR

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 21, 2019
@zetaab
Copy link
Member Author

zetaab commented Sep 21, 2019

/hold cancel

@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 21, 2019
@zetaab zetaab force-pushed the feature/floatingtype branch from de949cd to 026e258 Compare September 21, 2019 09:36
chrisz100
chrisz100 approved these changes Sep 21, 2019
View reviewed changes
Copy link
Contributor

@chrisz100 chrisz100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Feature gated for openstack so I don’t see this as any kind of deal breaker for anything.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 21, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrisz100, zetaab

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 5fa9425 into kubernetes:master Sep 21, 2019
@mikesplain mikesplain mentioned this pull request Sep 23, 2019
Merged
k8s-ci-robot added a commit that referenced this pull request Sep 23, 2019
@k8s-ci-robot
Merge pull request #7656 from mikesplain/automated-cherry-pick-of-#76…
2633dbb 
…44-origin-release-1.15

Automated cherry pick of #7644: Use without external router
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisz100 chrisz100 chrisz100 approved these changes

@drekle drekle Awaiting requested review from drekle

@robinpercy robinpercy Awaiting requested review from robinpercy

Assignees

@chrisz100 chrisz100

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zetaab @k8s-ci-robot @chrisz100