-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom sysctl Parameters #7730
Custom sysctl Parameters #7730
Conversation
Hi @ripta. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @gambol9 |
@ripta: GitHub didn't allow me to assign the following users: gambol9. Note that only kubernetes members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Oops. Would've been nice to not typo. /assign @gambol99 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
/retest |
@justinsb @mikesplain - Could I get a review? Also, looks like |
/retest |
Hi @ripta I just went over the PR and things are looking pretty good. Could you please add documentation for it before we go ahead and merge it. |
@rdrgmnzs - I added a section on |
/test pull-kops-verify-staticcheck |
This looks great. Thanks @ripta! /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mikesplain, ripta The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test pull-kops-e2e-kubernetes-aws |
…pstream-release-1.17 Automated cherry pick of #7730: Add SysctlParameters to ClusterSpec and InstanceGroupSpec
This adds a new
sysctlParameters
to cluster spec and instance group spec to allow setting custom runtime kernel parameters.I needed to be able to set sysctl parameters on our nodes. I considered adding a file asset, but we can't currently set the
OnChangeExecute
of aFile
nodetask that way. Since we already have a sysctl builder, this change seemed to be an obvious one.