-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(apiserver): allow multiple service-account-key-file #7781
fix(apiserver): allow multiple service-account-key-file #7781
Conversation
Welcome @hatappi! |
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Hi @hatappi. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/check-cla |
/assign @chrislovecnm |
/ok-to-test I confirmed the new test fails without the fix in place:
and that the test's expected output is what kube-apiserver requires for the flag. Thanks @hatappi ! |
Thanks @hatappi /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hatappi, justinsb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…-origin-release-1.15 Automated cherry pick of #7781: fix(apiserver): allow multiple service-account-key-file
What this PR does / why we need it:
Currently, an error occurs when multiple service-account-key-file are specified for kube-apiserver.
This PR will fix it.
Which issue(s) this PR fixes:
fixed #7645
Special notes for your reviewer: