cilium: don't try to mount sys/fs/bpf if already mounted #7832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justinsb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
Would be good to get this one merged |
|
/retest |
|
/retest |
rifelpet
reviewed
Dec 7, 2019
|
@justinsb Any update on this? We're seeing this and it's causing |
systemd v238 already includes the mount, and the unit file fails. We test for the existence of the mount, rather than testing systemd versions directly.
justinsb
force-pushed
the
cilium_dont_double_mount_bpf
branch
from
251a777 to
4d51485
Compare
k8s-ci-robot
added
size/M
|
/lgtm |
k8s-ci-robot
added
the
lgtm
This was referenced Dec 28, 2019
Merged
Merged
k8s-ci-robot
added a commit
that referenced
this pull request
Dec 30, 2019
…2-origin-release-1.17 Automated cherry pick of #7832: cilium: don't try to mount sys/fs/bpf if already mounted
k8s-ci-robot
added a commit
that referenced
this pull request
Jan 3, 2020
…2-origin-release-1.15 Automated cherry pick of #7832: cilium: don't try to mount sys/fs/bpf if already mounted
k8s-ci-robot
added a commit
that referenced
this pull request
Jan 3, 2020
…2-origin-release-1.16 Automated cherry pick of #7832: cilium: don't try to mount sys/fs/bpf if already mounted
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
systemd v238 already includes the mount, and the unit file fails. We
test for the existence of the mount, rather than testing systemd
versions directly.