Correct link error:404 #7954
Correct link error:404 #7954
Conversation
k8s-ci-robot
added
cncf-cla: yes
docs/single-to-multi-master.md
Outdated
| @@ -30,7 +30,7 @@ Please follow all the backup steps before attempting it. Please read the | |||
| [etcd admin guide](https://github.com/coreos/etcd/blob/v2.2.1/Documentation/admin_guide.md) | |||
| before attempting it. | |||
|
|
|||
| We can migrate from a single-master cluster to a multi-master cluster, but this is a complicated operation. It is easier to create a multi-master cluster using Kops (described [here](https://github.com/kubernetes/kops/blob/master/docs/high_availability.md)). If possible, try to plan this at time of cluster creation. | |||
| We can migrate from a single-master cluster to a multi-master cluster, but this is a complicated operation. It is easier to create a multi-master cluster using Kops (described [here](https://github.com/kubernetes/kops/blob/master/docs/single-to-multi-master.md)). If possible, try to plan this at time of cluster creation. | |||
There was a problem hiding this comment.
I think high_availability.md was moved into an operations subdirectory here:
https://github.com/kubernetes/kops/pull/7593/files#diff-e089e6f8aa55d07a58d6e6001cea4b32
so we could probably update this link to be a relative path: ./operations/high_availability.md
There was a problem hiding this comment.
Fixing the high_availability.md link to be a correct relative path is #7907
There was a problem hiding this comment.
Ok, I will solve this conflict.
But I suggest:
operations/high_availability.md -> https://github.com/kubernetes/kops/blob/master/docs/operations/high_availability.md
There was a problem hiding this comment.
It would be more effective to make that suggestion in the other PR. I currently disagree with the suggestion, but providing the reasoning behind the suggestion might help lead to a common understanding.
There was a problem hiding this comment.
@johnbelamaric
both are ok. But I think hyperlink is better.
There was a problem hiding this comment.
I think the universal format is more readable.
There was a problem hiding this comment.
They're both hyperlinks. The absolute one has the disadvantage that if one is viewing from a tag or branch, the link will go to the tip of master branch, not to the version relevant to where one started. The destination page might even no longer exist on the master branch.
yuxiaobo96
force-pushed
the
kops-link
branch
from
0e27213 to
2d72ba5
Compare
|
@rifelpet |
Signed-off-by: yuxiaobo <[email protected]>
yuxiaobo96
force-pushed
the
kops-link
branch
from
22b18e7 to
8a46284
Compare
|
ref:#7944 |
|
I think I was accidentally tagged here... /uncc |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rifelpet, yuxiaobo96 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Signed-off-by: yuxiaobo [email protected]