Add joshbranham to OWNERs as reviewer #8010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
YAAAS! The more the better! Josh has been getting involved lately and got to know everyone a bit at Kubecon so I think he could be of great use in the project! LGTMing and approving but holding to await other opinions! /lgtm |
k8s-ci-robot
added
do-not-merge/hold
|
welcome aboard officially! |
|
/approve Welcome! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chrisz100, joshbranham, mikesplain The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm
Welcome!
…On Fri, Nov 29, 2019, 3:57 AM Kubernetes Prow Robot < ***@***.***> wrote:
[APPROVALNOTIFIER] This PR is *APPROVED*
This pull-request has been approved by: *chrisz100
<#8010 (comment)>*, *joshbranham
<#8010#>*, *mikesplain
<#8010 (comment)>*
The full list of commands accepted by this bot can be found here
<https://go.k8s.io/bot-commands?repo=kubernetes%2Fkops>.
The pull request process is described here
<https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process>
Needs approval from an approver in each of these files:
- OWNERS <https://github.com/kubernetes/kops/blob/master/OWNERS>
[chrisz100,mikesplain]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#8010?email_source=notifications&email_token=ACIDOQD5H7VR66QC3CPZSCTQWD7TRA5CNFSM4JSA4BUKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFOV34Y#issuecomment-559767027>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACIDOQFEXDVNK6JXYSL4PP3QWD7TRANCNFSM4JSA4BUA>
.
|
|
Seems like consensus! Thanks @joshbranham! Welcome to the team! /hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In discussion with @mikesplain, adding myself as a reviewer to the project to assist moving forward!