Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alicloud: allow use RAM role for OSS client #8025

Merged
merged 1 commit into from
Dec 4, 2019
Merged

Alicloud: allow use RAM role for OSS client #8025

merged 1 commit into from
Dec 4, 2019

Conversation

bittopaz
Copy link
Contributor

This is part of #4127.

This is the first step to gradually move from environment variables ACCESS KEY and SECRET to instance RAM role (known as IAM role in EC2).

This is also related with kopeio/etcd-manager#269. After this PR gets merged, I will try make another separate PR to update the kops dependency to latest in etcd-manager.

Then kopeio/etcd-manager#269 can be merged.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 28, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @bittopaz. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 28, 2019
@zetaab
Copy link
Member

zetaab commented Nov 28, 2019

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 28, 2019
util/pkg/vfs/osscontext.go Outdated Show resolved Hide resolved
@zetaab
Copy link
Member

zetaab commented Dec 4, 2019

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 4, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bittopaz, zetaab

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 4, 2019
@k8s-ci-robot k8s-ci-robot merged commit e1f7d31 into kubernetes:master Dec 4, 2019
@bittopaz bittopaz deleted the ali-patch-7 branch December 4, 2019 10:53
k8s-ci-robot added a commit that referenced this pull request Jan 31, 2020
…-upstream-release-1.17

Automated cherry pick of #8025: Alicloud: allow use RAM role for OSS client
k8s-ci-robot added a commit that referenced this pull request Feb 7, 2020
…-upstream-release-1.16

Automated cherry pick of #8025: Alicloud: allow use RAM role for OSS client
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants