Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg/model pkg/diff pkg/client/:simplify code and remove unused code #8120

Merged
merged 1 commit into from
Dec 17, 2019
Merged

pkg/model pkg/diff pkg/client/:simplify code and remove unused code #8120

merged 1 commit into from
Dec 17, 2019

Conversation

tanjunchen
Copy link
Member

@tanjunchen tanjunchen commented Dec 16, 2019 •
edited
Loading

ref:#7800

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 16, 2019
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 16, 2019
@tanjunchen
Copy link
Member Author

/test pull-kops-verify-gofmt

@tanjunchen
Copy link
Member Author

/cc @justinsb @rifelpet

rifelpet
rifelpet reviewed Dec 16, 2019
View reviewed changes
pkg/model/network.go Outdated
}
// TODO: would be good to create these as shared, to verify them
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think putting this TODO comment above the if !sharedVPC { conditional that it was originally in might be more appropriate.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure.this seems good to me.
I will update it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, I meant above line 101. sorry. given theres no else case anymore, a comment related to an else case would probably be best above the if statement itself.

@tanjunchen
Copy link
Member Author

done

@rifelpet
Copy link
Member

thanks!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 16, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rifelpet, tanjunchen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 16, 2019
@tanjunchen
Copy link
Member Author

/test pull-kops-e2e-kubernetes-aws

@tanjunchen
Copy link
Member Author

/test pull-kops-bazel-test

@k8s-ci-robot k8s-ci-robot merged commit 32970d1 into kubernetes:master Dec 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rifelpet rifelpet rifelpet left review comments

@joshbranham joshbranham Awaiting requested review from joshbranham

@robinpercy robinpercy Awaiting requested review from robinpercy

@justinsb justinsb Awaiting requested review from justinsb

Assignees

@rifelpet rifelpet

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tanjunchen @rifelpet @k8s-ci-robot