Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix staticcheck failures in pkg/resources #8191

Merged
merged 1 commit into from
Dec 25, 2019
Merged

fix staticcheck failures in pkg/resources #8191

merged 1 commit into from
Dec 25, 2019

Conversation

Aresforchina
Copy link
Contributor

@Aresforchina Aresforchina commented Dec 24, 2019 •
edited
Loading

ref:#7800
Special notes:
pkg/resources/ali/ali.go:63:3: this value of region is never used (SA4006)
pkg/resources/ali/ali.go:427:27: this result of append is never used, except maybe in other appends (SA4010)
pkg/sshcredentials/fingerprint.go:57:6: func insertFingerprintColons is unused (U1000)
pkg/sshcredentials/fingerprint.go:25:2: imported and not used: "k8s.io/klog"
pkg/resources/ali/ali.go:427:13: append(roleToDelete, role.RoleId) evaluated but not used
pkg/resources/ali/ali.go:415:2: roleToDelete declared and not used

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 24, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @Aresforchina. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 24, 2019
@Aresforchina Aresforchina force-pushed the fix-staticcheck-pkg-resources01 branch from 9c115ee to d52bc22 Compare December 24, 2019 02:26
@Aresforchina
Copy link
Contributor Author

/assign @KashifSaadat

johngmyers
johngmyers requested changes Dec 24, 2019
View reviewed changes
pkg/resources/ali/ali.go Outdated
@@ -60,7 +60,7 @@ type clusterDiscoveryALI struct {

func ListResourcesALI(aliCloud aliup.ALICloud, clusterName string, region string) (map[string]*resources.Resource, error) {
if region == "" {
region = aliCloud.Region()
aliCloud.Region()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems nonsensical. If region is not used, then this whole if block should be removed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so...I will remove them together.

@Aresforchina Aresforchina force-pushed the fix-staticcheck-pkg-resources01 branch from d52bc22 to 318dcf8 Compare December 24, 2019 05:04
@tanjunchen
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 24, 2019
@Aresforchina
Copy link
Contributor Author

/test pull-kops-e2e-kubernetes-aws

@Aresforchina Aresforchina force-pushed the fix-staticcheck-pkg-resources01 branch from 318dcf8 to 8ebcea0 Compare December 24, 2019 09:13
@tanjunchen
Copy link
Member

/test pull-kops-e2e-kubernetes-aws

@rifelpet
Copy link
Member

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 25, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Aresforchina, rifelpet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 25, 2019
@k8s-ci-robot k8s-ci-robot merged commit 22ddc3b into kubernetes:master Dec 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johngmyers johngmyers johngmyers requested changes

@joshbranham joshbranham Awaiting requested review from joshbranham

@robinpercy robinpercy Awaiting requested review from robinpercy

Assignees

@rifelpet rifelpet

@KashifSaadat KashifSaadat

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Aresforchina @k8s-ci-robot @tanjunchen @rifelpet @johngmyers @KashifSaadat