-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix author nickName #8205
fix author nickName #8205
Conversation
Hi @LinshanYu. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hmmm - that's looks like it could be a bug in relnotes: https://github.com/kopeio/shipbot/blob/master/cmd/relnotes/main.go#L199 I don't know if relnotes is picking up the wrong field, or if the user renamed themselves. In any case, it looks like we should change MathieuMailhos to mmailhos throughout - including in the square bracket links (i.e. not just in the URLs) (I think?) Thanks for fixing this @LinshanYu - how did you find it? (Crawling for broken links?) |
Take a look the link,#6776 ,which the author of is shown in the document which i changed. Just open this link and you will find the real author address |
/ok-to-test |
Thanks @LinshanYu - I think the user has renamed themselves, and when I fed this back into /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justinsb, LinshanYu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Edit author nickname