Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stabilize sequence of "export xx=xxx" statements #8247

Merged
merged 1 commit into from
Jan 11, 2020
Merged

Stabilize sequence of "export xx=xxx" statements #8247

merged 1 commit into from
Jan 11, 2020

Conversation

bittopaz
Copy link
Contributor

@bittopaz bittopaz commented Jan 2, 2020

The "export xx=xxx" statements are added to user data scripts.

But when reading environment variables from map[string]string, the sequence is not stable, this will result unnecessary changes to user data in launch configuration.

By sorting the keys in this environment variables map, we can make the "export xx=xxx" statements stable.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 2, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @bittopaz. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 2, 2020
@rifelpet
Copy link
Member

rifelpet commented Jan 3, 2020

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 3, 2020
@bittopaz
Copy link
Contributor Author

bittopaz commented Jan 3, 2020

/retest

@rifelpet
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 11, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bittopaz, rifelpet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 11, 2020
@k8s-ci-robot k8s-ci-robot merged commit 2711ed3 into kubernetes:master Jan 11, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Jan 11, 2020
@bittopaz bittopaz deleted the fix-env-vars branch January 11, 2020 15:48
k8s-ci-robot added a commit that referenced this pull request Feb 11, 2020
…247-origin-release-1.17

Automated cherry pick of #8247 release-1.17
k8s-ci-robot added a commit that referenced this pull request Feb 12, 2020
…247-origin-release-1.16

Automated cherry pick of #8247 origin/release-1.16
k8s-ci-robot added a commit that referenced this pull request Feb 12, 2020
…247-origin-release-1.15

Automated cherry pick of #8247 release 1.15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants