-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stabilize sequence of "export xx=xxx" statements #8247
Conversation
Hi @bittopaz. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
/retest |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bittopaz, rifelpet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…247-origin-release-1.17 Automated cherry pick of #8247 release-1.17
…247-origin-release-1.16 Automated cherry pick of #8247 origin/release-1.16
…247-origin-release-1.15 Automated cherry pick of #8247 release 1.15
The "export xx=xxx" statements are added to user data scripts.
But when reading environment variables from
map[string]string
, the sequence is not stable, this will result unnecessary changes to user data in launch configuration.By sorting the keys in this environment variables map, we can make the "export xx=xxx" statements stable.