Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make /opt/kops writeable on COS #8269

Merged
merged 2 commits into from
Jan 6, 2020

Conversation

justinsb
Copy link
Member

@justinsb justinsb commented Jan 4, 2020

This approach means that rather than trying to have different
directories on different OSes, we can instead make them look more
similar.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 4, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 4, 2020
This approach means that rather than trying to have different
directories on different OSes, we can instead make them look more
similar.
@justinsb justinsb force-pushed the ops_kops_writeable branch from dc47f6c to 42732ea Compare January 4, 2020 23:00
/opt/ isn't writeable on COS, so we download to /var/lib/toolbox/kops
instead.
@justinsb justinsb force-pushed the ops_kops_writeable branch from 42732ea to 6c41748 Compare January 4, 2020 23:16
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 4, 2020
@justinsb
Copy link
Member Author

justinsb commented Jan 5, 2020

/retest

Storage flake

@rifelpet
Copy link
Member

rifelpet commented Jan 5, 2020

/test pull-kops-e2e-kubernetes-aws

@KashifSaadat
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 6, 2020
@k8s-ci-robot k8s-ci-robot merged commit 6393090 into kubernetes:master Jan 6, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants