Alicloud: Refactor LoadBalancerWhiteList to LoadBalancerACL

[bittopaz]

This is part of #4127.

Changes:

1. LoadBalancerWhiteList was created before Alicloud came up with LoadBalancerAccessControlList, and also the APIs of AccessControlList is more elegant
2. This is the first step to migrate from aliyungo to official Alicloud SDK, since aliyungo is not actively maintained

[k8s-ci-robot]

Hi @bittopaz. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[rifelpet]

/ok-to-test

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[bittopaz]

This is still relevant. It would be super nice if someone could help review.
Thanks in advance.

[hakman]

@bittopaz Sorry for the delay here. Would it be ok for you to rebase and I could take a look at the changes after that to review them?

[hakman]

/remove-lifecycle stale

[bittopaz]

@hakman Thanks you for looking at this.
I just rebased the changes to master branch.

[hakman]

Thanks @bittopaz. Will try to review this during the weekend.

[hakman]

Does this also migrate users from LoadBalancerWhiteLists to LoadBalancerAccessControlList?
I guess I mean to ask if this migration doesn't break anything from the user's point of view.

[bittopaz]

@hakman this won’t break anything. It’s just a rename, existing whitelist would be found in the new named resource, so nothing would change.

And meanwhile, I guess I’m probably the only kops user with Alicloud. 😄

[hakman]

/test pull-kops-verify-gomod

[hakman]

As I cannot test this, but changes seem reasonable...
/lgtm
/assign @rifelpet

[rifelpet]

I can't test it either but it looks good to me too. one last question, can we delete upup/pkg/fi/cloudup/alitasks/loadbalancerwhitelist.go and loadbalancerwhitelist_fitask.go now? Should that be in this PR or a separate PR?

[bittopaz]

@rifelpet This is already deleted/renamed in a95d592.

[rifelpet]

Ah you're right, my apologies for missing that. Sorry, it looks like you'll need one last rebase.

[bittopaz]

Rebased to resolve conflicts.

[rifelpet]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bittopaz, rifelpet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [rifelpet]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment