Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #7865: feat(api): DeleteOnTermination fields for volumes #8426

Merged
merged 6 commits into from
Jan 29, 2020
Merged

Automated cherry pick of #7865: feat(api): DeleteOnTermination fields for volumes #8426

merged 6 commits into from
Jan 29, 2020

Conversation

moensch
Copy link

@moensch moensch commented Jan 28, 2020

Cherry pick of #7865 on release-1.16.

#7865: feat(api): DeleteOnTermination fields for volumes

For details on the cherry pick process, see the cherry pick requests page.

tioxy added 6 commits January 28, 2020 00:48
@tioxy @moensch
feat(api): DeleteOnTermination fields for volumes
c14fd3d 
Support RootVolumeDeleteOnTermination and DeleteOnTermination fields
to enable a deeper customization
@tioxy @moensch
feat(awstasks): Support EBS DeleteOnTermination
9044727 
Change BDM behavior when finding Launch Configuration and generating
Cloudformation/Terraform
@tioxy @moensch
feat(awsmodel): Logic for EBS DeleteOnTermination
b97d12d 
Implement separated logics for root volume and additional volumes
@tioxy @moensch
test: Volume integration in update_cluster/complex
318a8e1 
Add rootVolumeDeleteOnTermination and deleteOnTermination to test if
volumes are being retained properly in direct, terraform and
cloudformation
@tioxy @moensch
docs(api): Default value for deleteOnTermination
e40ad2b 
State default value for both deleteOnTermination and
rootVolumeDeleteOnTermination equals to true
@tioxy @moensch
chore(api): deleteOnTermination codegen
0dc342b 
Codegen for deleteOnTermination and rootVolumeDeleteOnTermination (crds
and apis)
@k8s-ci-robot k8s-ci-robot added this to the v1.16 milestone Jan 28, 2020
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 28, 2020
@k8s-ci-robot
Copy link
Contributor

Welcome @moensch!

It looks like this is your first PR to kubernetes/kops 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kops has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @moensch. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 28, 2020
@hakman
Copy link
Member

hakman commented Jan 28, 2020

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 28, 2020
@justinsb
Copy link
Member

We do want to release 1.16 beta (very) soon, but we haven't done so yet. I also re-read the code and this seems both additive and low-risk.

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 29, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb, moensch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 29, 2020
@k8s-ci-robot k8s-ci-robot merged commit 36cc820 into kubernetes:release-1.16 Jan 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@granular-ryanbonham granular-ryanbonham Awaiting requested review from granular-ryanbonham

@mikesplain mikesplain Awaiting requested review from mikesplain

Assignees

@justinsb justinsb

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.16
Development

Successfully merging this pull request may close these issues.
5 participants
@moensch @k8s-ci-robot @hakman @justinsb @tioxy