Make it possible to enable Prometheus metrics for Cilium

[olemarkus]

Another bug in the new templates is the loss of prometheus metrics.

Since there are more cilium components involved here, the old config param didn't make that much sense anymore, so I rewrote that part.

Since the property is removed, this sort of breaks BC, but nothing would have happened for those that did so no loss of functionality.

/kind bug

[k8s-ci-robot]

Hi @olemarkus. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[rifelpet]

/ok-to-test

[olemarkus]

@rifelpet anything holding this one back?

[olemarkus]

/retest

[olemarkus]

/test pull-kops-e2e-kubernetes-aws

[johngmyers]

Do we allow removals like this?

[olemarkus]

That is indeed the question. At some point we do because it is just confusing for end users if we leave it in. And no one can be using that since it doesn't do anything.

If we have a more clear deprecation guide, I can do the removal in a second PR.

[johngmyers]

My understanding is that we need to leave them in unused. When we create a new API version, then we can remove it from the new version. My understanding might be inaccurate and I don't know how we're tracking items to change in the next API revision.

[olemarkus]

I removed this bit now. Can be fixed at a later time, I guess

[johngmyers]

/retest

[rifelpet]

Ideally we could have this under test here but that could be tackled in a followup PR. You'd need to add the cilium addon manifest name to this list as well.

Thanks!

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: olemarkus, rifelpet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [rifelpet]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[rifelpet]

And yes we should open a GH issue that tracks any breaking changes we want to make across the entire kops API like removing the unused prometheusServeAddr field

[olemarkus]

/retest