-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GCS: Don't try to set ACLs if bucket-policy only is set #8493
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justinsb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This means we won't be able to work unless there's a bucket permission (which actually will typically happen if the state store is in the same GCS project). This is the minimal workaround for cherry-picking.
Some background: we set ACLs to enable a remote GCS bucket. But if the bucket has uniform bucket level access then we simply can't set ACLs. For the common case where the kops-state-store GCS bucket is in the same project, we likely don't need these ACLs anyway, so this is a minimal fix to unblock functionality there, that we can cherry-pick. Future PRs will try to handle the cross-project case, but we probably wouldn't cherry-pick them. |
Looking forward to our kops-gce job turning green :) /lgtm |
Cherry pick of #8493 onto release-1.15
Cherry pick of #8493 onto release-1.17
Cherry pick of #8493 onto release-1.16
This means we won't be able to work unless there's a bucket permission
(which actually will typically happen if the state store is in the
same GCS project).
This is the minimal workaround for cherry-picking.