Added Launch Template support for instance interruption behavior

[martin-tomes]

ref: #8809

Updated Launch Template with spot instance interruption behavior

[k8s-ci-robot]

Hi @tomesm. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[hakman]

Very nice! You many need to run hack/update-expected.sh to fix tests.
/ok-to-test

[martin-tomes]

/retest

[rifelpet]

This looks better now! I had to commit a change to your branch but the tests are now passing. one last thing is that I think launchtemplate_target_api.go needs to be updated as well. that way users with --target direct will be able to use the field. It should just be a matter of adding the new field to the RenderAWS and Find functions.

[martin-tomes]

@rifelpet Thanks for removing the trailing space.

Before I commit anything I just want to be sure If I understand it right.

For RenderAWS for example I believe this must be added under InstanceMarketOptions, am I right?

[rifelpet]

InstanceInterruptionBehavior would go in the LaunchTemplateSpotMarketOptionsRequest struct. The RenderAWS functions all use the types defined in the AWS SDK, so you can see the fields there:

https://docs.aws.amazon.com/sdk-for-go/api/service/ec2/#LaunchTemplateSpotMarketOptionsRequest

[martin-tomes]

@rifelpet well, I am adding it to the LaunchTemplateSpotMarketOptionsRequest struct... and this struct is part of LaunchTemplateInstanceMarketOptionsRequest which is, based on my understanding, needed to create InstanceMarketOptions under RequestLaunchTemplateData struct.

So I am not sure what I am doing wrong here :)

[rifelpet]

everything you said sounds correct. can you push the commit here so we can take a look at any errors?

[rifelpet]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rifelpet, tomesm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [rifelpet]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[rifelpet]

/retest

[rifelpet]

/retest