Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update alpha channels with May updates #9155

Merged
merged 1 commit into from
May 21, 2020

Conversation

moshevayner
Copy link
Member

No description provided.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 21, 2020
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 21, 2020
@hakman
Copy link
Member

hakman commented May 21, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 21, 2020
@rifelpet
Copy link
Member

rifelpet commented May 21, 2020

I think we'll want to add 1.18 to the alpha channel at some point. I don't recall exactly when in the kops release cycle that gets added though.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MoShitrit, rifelpet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 21, 2020
@k8s-ci-robot k8s-ci-robot merged commit d9b15cf into kubernetes:master May 21, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone May 21, 2020
@moshevayner moshevayner deleted the update-k8s-versions branch May 21, 2020 12:33
@moshevayner
Copy link
Member Author

I think we'll want to add 1.18 to the alpha channel at some point. I don't recall exactly when in the kops release cycle that gets added though.

/approve

@rifelpet Yeah, I thought about that too, but since I didn't see a release branch for 1.18, I wasn't sure if there's a specific time in which we add the new version to play.
If you think now is a good time- I can add it through a new PR since this one is already merged 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants