Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add olemarkus as reviewer #9200

Merged
merged 1 commit into from
Jun 19, 2020
Merged

Conversation

hakman
Copy link
Member

@hakman hakman commented May 28, 2020

@olemarkus has been an active contributor and reviewer for some time now and I think he would make a great addition to the Kops reviewers.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 28, 2020
@hakman
Copy link
Member Author

hakman commented May 28, 2020

/cc @justinsb

@k8s-ci-robot k8s-ci-robot requested a review from justinsb May 28, 2020 14:09
@johngmyers
Copy link
Member

Technically, @olemarkus isn't eligible until Jun 24.

@hakman
Copy link
Member Author

hakman commented May 28, 2020

Technically, @olemarkus isn't eligible until Jun 24.

Not that far away though. If this is a hard requirement, I guess we can hold for another 3 weeks.

@rdrgmnzs
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 19, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman, rdrgmnzs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 19, 2020
@k8s-ci-robot k8s-ci-robot merged commit 58d1a2e into kubernetes:master Jun 19, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Jun 19, 2020
@hakman hakman deleted the reviewer-olemarkus branch July 1, 2020 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants