-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update adding_a_feature.md with more modern example #9208
Update adding_a_feature.md with more modern example #9208
Conversation
I think it is a huge improvement over what was already there. And an extra test to boot! At some point we need to tie some of those development pages more together. E.g with testing.md. /lgtm |
Unfortunately, API validation tests have about the least value to effort. They test internal APIs and fail to test the description of the error messages. It probably would be worthwhile to add an integration test for ENI mode and document the process. Is there a good way to test nodeup model code other than the e2e testgrid? |
625fb30
to
65a0ef5
Compare
/lgtm Thanks for adding link to the api update docs.. I am not sure of a better way to test nodeup model code. |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johngmyers, rifelpet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Move away from nodeup model files. This one is light on testing and the history is a bit revisionist, but there weren't a lot of examples that touched api, validation, and nodeup.
/cc @olemarkus