Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump supported and recommended k8s versions for kops 1.19 #9226

Merged
merged 4 commits into from
Jun 4, 2020
Merged

Bump supported and recommended k8s versions for kops 1.19 #9226

merged 4 commits into from
Jun 4, 2020

Conversation

johngmyers
Copy link
Member

/milestone v1.19
/hold
(for 1.18 to branch)

@k8s-ci-robot
Copy link
Contributor

@johngmyers: You must be a member of the kubernetes/kops-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your Kops Maintainers and have them propose you as an additional delegate for this responsibility.

In response to this:

/milestone v1.19
/hold
(for 1.18 to branch)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels May 31, 2020
@johngmyers johngmyers changed the title Bump supported and recommeded k8s versions for kops 1.19 Bump supported and recommended k8s versions for kops 1.19 May 31, 2020
@rifelpet rifelpet added this to the v1.19 milestone May 31, 2020
moshevayner
moshevayner reviewed Jun 1, 2020
View reviewed changes
docs/tutorial/upgrading-kubernetes.md
nodes-km98 Ready 10m v1.7.7 35.194.25.144 Ubuntu 16.04.3 LTS 4.10.0-35-generic
nodes-wbb2 Ready 2m v1.7.7 35.188.177.16 Ubuntu 16.04.3 LTS 4.10.0-35-generic
master-us-central1-a-8fcc Ready 26m v1.17.7 35.194.56.129 Container-Optimized OS from Google 4.4.35+
nodes-9cml Ready 16m v1.17.7 35.193.12.73 Ubuntu 16.04.3 LTS 4.10.0-35-generic
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also update the image versions of Ubuntu to 18.04 / 20.04? Or is 16.04 still the default for now?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't bother to research that.

@johngmyers
Copy link
Member Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 2, 2020
@moshevayner
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 2, 2020
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 3, 2020
@johngmyers johngmyers force-pushed the adjust-k8s-supported branch from 09a8322 to 46137c7 Compare June 3, 2020 17:37
@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jun 3, 2020
@hakman
Copy link
Member

hakman commented Jun 3, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 3, 2020
johngmyers
johngmyers commented Jun 4, 2020
View reviewed changes
pkg/model/components/docker.go
}
// TODO(justinsb): The ContainerOS image now has docker configured to use overlay2 out-of-the-box
// and it is an error to specify the flag twice.
docker.Storage = fi.String("overlay2,overlay,aufs")
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hakman Are overlay and aufs still relevant? (It would be a separate PR if not.)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All supported distros should have support for overlay2, so I think you are right and the rest could be removed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing this completely is also a possibility, as Docker already has a pretty good list of priorities:
https://github.com/docker/docker-ce/blob/v19.03.11/components/engine/daemon/graphdriver/driver_linux.go#L51

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I look forward to your future PR.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@johngmyers johngmyers force-pushed the adjust-k8s-supported branch from 46137c7 to 1936d23 Compare June 4, 2020 02:28
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 4, 2020
@hakman
Copy link
Member

hakman commented Jun 4, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 4, 2020
hakman
hakman reviewed Jun 4, 2020
View reviewed changes
pkg/model/components/etcdmanager/options.go
etcdCluster.Version = "3.2.18"
} else {
// Preserve existing default etcd version
etcdCluster.Version = "2.2.1"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove 2.2.1 also from supportedEtcdVersions.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cannot. Used as default for legacy provider with k8s 1.11 and 1.12

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah.. Thanks

hakman
hakman reviewed Jun 4, 2020
View reviewed changes
pkg/model/components/etcd.go
} else {
c.Version = DefaultEtcd2Version
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove also const DefaultEtcd2Version.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cannot. Several remaining references.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 4, 2020
@johngmyers johngmyers force-pushed the adjust-k8s-supported branch from 9df2bad to 2b81bad Compare June 4, 2020 19:14
@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jun 4, 2020
@hakman
Copy link
Member

hakman commented Jun 4, 2020

Would be nice to get this merged. Feels like there's a few rebases every day.
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 4, 2020
@rifelpet
Copy link
Member

rifelpet commented Jun 4, 2020

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johngmyers, rifelpet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 4, 2020
@k8s-ci-robot k8s-ci-robot merged commit dc7b3d3 into kubernetes:master Jun 4, 2020
@johngmyers johngmyers deleted the adjust-k8s-supported branch June 4, 2020 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hakman hakman hakman left review comments

@moshevayner moshevayner moshevayner left review comments

@gjtempleton gjtempleton Awaiting requested review from gjtempleton

@zetaab zetaab Awaiting requested review from zetaab

Assignees

@hakman hakman

@moshevayner moshevayner

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/api area/documentation area/nodeup cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.
5 participants
@johngmyers @k8s-ci-robot @moshevayner @hakman @rifelpet