Copy "portmap" to /opt/cni/bin for Weave

[hakman]

Weave requires portmap that seems to be missing at the moment:
https://www.weave.works/docs/net/latest/kubernetes/kube-addon/#-installation

e2e tests are failing because of the missing portmap plugin:
https://testgrid.k8s.io/kops-network-plugins#kops-aws-cni-weave

E0608 09:35:30.294544    5002 kubelet.go:2187] Container runtime network not ready: NetworkReady=false reason:NetworkPluginNotReady message:docker: network plugin is not ready: cni config uninitialized
I0608 09:35:33.143148    5002 kubelet.go:1952] SyncLoop (PLEG): "weave-net-6v74s_kube-system(14526285-9260-43e3-8c5e-62eb340b2dc1)", event: &pleg.PodLifecycleEvent{ID:"14526285-9260-43e3-8c5e-62eb340b2dc1", Type:"ContainerStarted", Data:"6cea0ffccafd5578fc62e565b78258d4d10bc6fc11be27b5e1990fbc0b40cf2e"}
W0608 09:35:34.281513    5002 cni.go:202] Error validating CNI config list {
    "cniVersion": "0.3.0",
    "name": "weave",
    "plugins": [
        {
            "name": "weave",
            "type": "weave-net",
            "hairpinMode": true
        },
        {
            "type": "portmap",
            "capabilities": {"portMappings": true},
            "snat": true
        }
    ]
}
: [failed to find plugin "portmap" in path [/opt/cni/bin/]]
W0608 09:35:34.282448    5002 cni.go:237] Unable to update cni config: no valid networks found in /etc/cni/net.d/

[olemarkus]

Hm. I thought the daemonset deployed this. Thanks for fixing.

/lgtm

[hakman]

Thanks @olemarkus. I checked the weave code and it's not the case.
Btw, I think there's something wrong with amazonvpc also and may be related.

[olemarkus]

/assign @mikesplain

[hakman]

e2e test failure is related to kubernetes/test-infra#17864

[olemarkus]

It may be that you have to add "loopback" too. This one isn't used by the CNI, but used by kubernetes internally.
If that is the case you should see something like

  Warning  FailedCreatePodSandBox  7m24s (x4 over 7m27s)    kubelet, ip-10-140-60-250.eu-central-1.compute.internal  (combined from similar events): Failed to create pod sandbox: rpc error: code = Unknown desc = failed to set up sandbox container "8e7c8b6aaf6ac0c5a84b8326a724f69b6f21e9d1c5b055e42081b88d70816dd7" network for pod "kube-dns-autoscaler-7647db5967-lwdjw": networkPlugin cni failed to set up pod "kube-dns-autoscaler-7647db5967-lwdjw_kube-system" network: failed to find plugin "loopback" in path [/opt/cni/bin/]

[hakman]

I didn't notice this while testing, so let's see how tests go in TestGrid.

[mikesplain]

Thanks!

/lgtm
/approve

[hakman]

Thanks guys :)

[hakman]

/retest

[mikesplain]

/retest

[hakman]

/retest

[hakman]

/retest

[johngmyers]

/retest

[hakman]

@mikesplain I think somehow the bot did not see the approval.

[mikesplain]

Ahh yeah, it removed it since the branch was pushed again.

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman, mikesplain

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [mikesplain]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment