Validate cilium version #9295
Merged
Validate cilium version #9295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
area/api
size/L
johngmyers
requested changes
Jun 8, 2020
|
/retest |
|
/assign @mikesplain |
olemarkus
force-pushed
the
cilium-component
branch
from
a1abb7b to
b27e44f
Compare
|
Just the one remaining nit for me. |
olemarkus
force-pushed
the
cilium-component
branch
from
b27e44f to
e9d4e3f
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Merged
rifelpet
reviewed
Jun 15, 2020
rifelpet
reviewed
Jun 15, 2020
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: olemarkus, rifelpet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is a bit too easy for Cilium users to configure unsupported combinations of cilium version and features. This PR ensures that users only set a supported version. Plan on follow-ups that will validate various features as well.