Use Docker 19.03.11 for Kubernetes 1.17+ #9317
Conversation
k8s-ci-robot
added
cncf-cla: yes
|
|
||
| // 19.03.4 - Debian Buster | ||
| { | ||
| PackageVersion: "19.03.4", |
There was a problem hiding this comment.
I don't think we should be removing these, since 19.03.4 is still a supported option in validation.go
There was a problem hiding this comment.
We don't remove it, it remains as static package for all distros.
hakman
force-pushed
the
docker-19.03.11-k8s-1.17
branch
from
987d46a to
9c13e7f
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
k8s-ci-robot
removed
the
lgtm
|
Same treatment for containerd versions. |
| Architectures: []architectures.Architecture{architectures.ArchitectureAmd64}, | ||
| Source: "https://storage.googleapis.com/cri-containerd-release/cri-containerd-1.2.10.linux-amd64.tar.gz", | ||
| Hash: "9125a6ae5a89dfe9403fea7d03a8d8ba9fa97b6863ee8698c4e6c258fb14f1fd", | ||
| }, | ||
|
|
||
| // 1.2.11 - Linux Generic |
There was a problem hiding this comment.
I presume you're planning on removing support for these four versions from 1.18 as well.
I notice we don't have API validation for the containerd version.
There was a problem hiding this comment.
Yes, will cherry-pick to 1.18 also. These were only used during development and current versions will be the final ones for 1.18 (unless some big issue comes up).
There was a problem hiding this comment.
The version validation for Docker was a bit rushed up when 1.x support was removed.
Thanks for the reminder to add validation for containerd also.
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman, rifelpet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
…pstream-release-1.18 Automated cherry pick of #9317: Use Docker 19.03.11 for Kubernetes 1.17+
As discussed during Office Hours, the default Docker version for Kubernetes 1.17+ should be 19.03.11.