Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fold multiple integration test cases into the complex test case #9409

Merged
merged 1 commit into from
Jun 20, 2020

Conversation

rifelpet
Copy link
Member

@rifelpet rifelpet commented Jun 19, 2020

Each integration test case adds many LoC and some overhead in running the integration tests.

Since many of the tests are only testing a specific feature, it would be simpler to combine all of the non-mutually exclusive features into the single complex case. We could probably do this to more of the test cases but this was my first high level pass.

WIP while I figure out this test failure. hack/verify-expected.sh reports that it found a difference and wrote it to the files but there aren't any actual changes to the file afterwards...

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jun 19, 2020
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 19, 2020
@rifelpet
Copy link
Member Author

oh, i remember this happening before. its because we run 3 test cases for complex and one of them changes the file to one thing and a later test (looks like the legacy apiVersion test) changes it back. end result is the same incorrect file. ill see if i can split that up somehow.

@rifelpet rifelpet force-pushed the integration-test-reduce branch from 0b4992c to 78def76 Compare June 20, 2020 02:35
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rifelpet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rifelpet rifelpet marked this pull request as ready for review June 20, 2020 02:49
@rifelpet rifelpet changed the title WIP Fold multiple integration test cases into the complex test case Fold multiple integration test cases into the complex test case Jun 20, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 20, 2020
Each integration test cluster adds many LoC and some overhead in running the integration tests.
Since many of the tests are only testing a specific feature, it would be simpler to combine all of the non-mutually exclusive features into the complex cluster.
@rifelpet rifelpet force-pushed the integration-test-reduce branch from 78def76 to 75ccf45 Compare June 20, 2020 03:09
@hakman
Copy link
Member

hakman commented Jun 20, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 20, 2020
@k8s-ci-robot k8s-ci-robot merged commit 80e1da9 into kubernetes:master Jun 20, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Jun 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants