-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update bazel rules versions #9428
Conversation
looks like rules_go updated the output path of binaries: https://github.com/bazelbuild/rules_go/releases/tag/v0.23.0 from |
e15284c
to
fccf0e3
Compare
Thanks for looking at this @rifelpet - it looks like we'll have to tackle this as part of rules-go 0.23. It looks like k/kubernetes and even k/test-infra are holding on 0.22.6 (which adds support for the newer go versions). I suspect we don't want to be an early adopter here - should we hold this one until e.g. test-infra shows us how to go to 0.23, but in the meantime we can go to 0.22.6? |
fccf0e3
to
500a609
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rifelpet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
500a609
to
03e620b
Compare
Ah good eye. I just updated this to 0.22.6 to match upstream. I believe that k/k doesn't use bazel to build release binaries, only we can also consider upgrading to go 1.14 and updating k/k dependencies to 1.19 |
/lgtm |
/hold cancel |
In preparation for updating to go 1.14, we need to at least update rules_go. I updated the other rules while I was at it.