Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bazel rules versions #9428

Merged
merged 1 commit into from
Jul 6, 2020

Conversation

rifelpet
Copy link
Member

In preparation for updating to go 1.14, we need to at least update rules_go. I updated the other rules while I was at it.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 23, 2020
@k8s-ci-robot k8s-ci-robot requested review from olemarkus and zetaab June 23, 2020 01:19
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 23, 2020
@rifelpet
Copy link
Member Author

rifelpet commented Jun 23, 2020

looks like rules_go updated the output path of binaries: https://github.com/bazelbuild/rules_go/releases/tag/v0.23.0 from bazel-bin/cmd/kops/linux_amd64_pure_stripped/kops to bazel-bin/cmd/kops/kops_/kops. We're now encouraged to use "configuration transitions" for multi-arch builds, which I'm still reading up on. If someone knows what changes need to be made feel free to suggest them.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 23, 2020
@rifelpet rifelpet force-pushed the bazel-rules-update branch 5 times, most recently from e15284c to fccf0e3 Compare June 23, 2020 16:39
@rifelpet
Copy link
Member Author

bazel make targets are passing but i'm not happy with how we're copying from bazel-bin to BAZELUPLOAD after each bazel build command.

Maybe theres a better way?
/assign @justinsb
/hold for comment

Also noticed that this issue is resolved so we might be able to take advantage of that too.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 23, 2020
@justinsb
Copy link
Member

justinsb commented Jul 5, 2020

Thanks for looking at this @rifelpet - it looks like we'll have to tackle this as part of rules-go 0.23. It looks like k/kubernetes and even k/test-infra are holding on 0.22.6 (which adds support for the newer go versions). I suspect we don't want to be an early adopter here - should we hold this one until e.g. test-infra shows us how to go to 0.23, but in the meantime we can go to 0.22.6?

@rifelpet rifelpet force-pushed the bazel-rules-update branch from fccf0e3 to 500a609 Compare July 5, 2020 21:36
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 5, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rifelpet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rifelpet rifelpet force-pushed the bazel-rules-update branch from 500a609 to 03e620b Compare July 5, 2020 21:39
@rifelpet
Copy link
Member Author

rifelpet commented Jul 5, 2020

Ah good eye. I just updated this to 0.22.6 to match upstream. I believe that k/k doesn't use bazel to build release binaries, only go test -c -o https://github.com/kubernetes/kubernetes/blob/master/hack/lib/golang.sh#L677 so perhaps we consider doing that too.

we can also consider upgrading to go 1.14 and updating k/k dependencies to 1.19

@rifelpet rifelpet mentioned this pull request Jul 5, 2020
@hakman
Copy link
Member

hakman commented Jul 6, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 6, 2020
@rifelpet
Copy link
Member Author

rifelpet commented Jul 6, 2020

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 6, 2020
@k8s-ci-robot k8s-ci-robot merged commit 35c77d7 into kubernetes:master Jul 6, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Jul 6, 2020
@rifelpet rifelpet deleted the bazel-rules-update branch October 29, 2020 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants