Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating the YAMLs for Ingress-Citrix Addon #9480

Merged
merged 1 commit into from
Jul 4, 2020

Conversation

christus02
Copy link
Contributor

@christus02 christus02 commented Jul 2, 2020

Updating the manifest files for newer version of Citrix Ingress Controller and making it generic.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 2, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @christus02. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 2, 2020
@christus02
Copy link
Contributor Author

/assign @mikesplain

@christus02
Copy link
Contributor Author

@mikesplain Could you please help in approving this PR? We have just modified the manifest files for the Citrix Ingress controller addon.

@johngmyers
Copy link
Member

I like the tightening of the RBAC verbs.
You might need to push again to clear the Netlify failure.
/ok-to-test
/lgtm

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 2, 2020
@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Jul 2, 2020
@christus02
Copy link
Contributor Author

I like the tightening of the RBAC verbs.
You might need to push again to clear the Netlify failure.
/ok-to-test
/lgtm

@johngmyers How do I get over the netlify failures? Pushing again did not help? Is there a way to skip it?

@rifelpet
Copy link
Member

rifelpet commented Jul 2, 2020

It looks like the netlify failures are unrelated and not flakes. I'm not sure if its an issue on netlify's side or ours but I can try to take a look soon if no one else gets to it before me. If its an issue on our side that requires a PR you'll need to rebase once that PR is merged.

@hakman
Copy link
Member

hakman commented Jul 3, 2020

Simplest way to rerun the tests would be to close and reopen the PR.

@christus02
Copy link
Contributor Author

/retest

@christus02 christus02 closed this Jul 4, 2020
@christus02 christus02 reopened this Jul 4, 2020
@christus02
Copy link
Contributor Author

Closed and re-opened the PR in order to rerun the tests (as per the suggestion)

@hakman
Copy link
Member

hakman commented Jul 4, 2020

@christus02 can you rebase and force push? Your branch hasn't been updated for some time.

@hakman
Copy link
Member

hakman commented Jul 4, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 4, 2020
@christus02
Copy link
Contributor Author

The netlify failures got resolved after rebasing. Can this PR be merged now?

@rifelpet
Copy link
Member

rifelpet commented Jul 4, 2020

Thanks!
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christus02, rifelpet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 4, 2020
@k8s-ci-robot k8s-ci-robot merged commit 89b0e05 into kubernetes:master Jul 4, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Jul 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants