-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating the YAMLs for Ingress-Citrix Addon #9480
Conversation
Hi @christus02. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @mikesplain |
@mikesplain Could you please help in approving this PR? We have just modified the manifest files for the Citrix Ingress controller addon. |
I like the tightening of the RBAC verbs. |
@johngmyers How do I get over the netlify failures? Pushing again did not help? Is there a way to skip it? |
It looks like the netlify failures are unrelated and not flakes. I'm not sure if its an issue on netlify's side or ours but I can try to take a look soon if no one else gets to it before me. If its an issue on our side that requires a PR you'll need to rebase once that PR is merged. |
Simplest way to rerun the tests would be to close and reopen the PR. |
/retest |
Closed and re-opened the PR in order to rerun the tests (as per the suggestion) |
@christus02 can you rebase and force push? Your branch hasn't been updated for some time. |
/lgtm |
The netlify failures got resolved after rebasing. Can this PR be merged now? |
Thanks! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: christus02, rifelpet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Updating the manifest files for newer version of Citrix Ingress Controller and making it generic.