Automated cherry pick of #9465: Update the service manifest for Docker

[hakman]

Cherry pick of #9465 on release-1.18.

#9465: Update the service manifest for Docker

For details on the cherry pick process, see the cherry pick requests page.

[hakman]

/assign @rifelpet

[johngmyers]

Does this really need to get into 1.18? It's a fairly big set of changes.

[hakman]

@johngmyers Except for the vendoring of github.com/blang/semver/v4, this change is pretty small and limited to Docker manifest rendering.
Some of it is needed. If there are concerns, I can strip a large part of it.

[hakman]

I think that should do it @johngmyers .

[hakman]

/retest

[johngmyers]

/lgtm

[rifelpet]

can you explain why the semver vendoring wasn't needed? that was to conditionally add containerd as a dependency in the mainfest right? doesn't 1.18 support containerd?

[hakman]

can you explain why the semver vendoring wasn't needed? that was to conditionally add containerd as a dependency in the mainfest right? doesn't 1.18 support containerd?

You are correct. The docker - containerd service dependency is nice to have, but not mandatory. Services will be started independently, but they sync without much trouble.

[rifelpet]

👍
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman, rifelpet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [rifelpet]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[hakman]

Thanks @rifelpet :)