Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cloudmock cleanup - preparation for EC2 tag-on-create #9520

Merged
merged 4 commits into from
Jul 8, 2020

Conversation

rifelpet
Copy link
Member

@rifelpet rifelpet commented Jul 8, 2020

In order to add "tag-on-create" support for ec2 resources, cloudmock first needs to support recognizing and storing tags provided in ec2.Create* requests. This way a DescribeTags call will return the tags provided either by the resource's Create call or in a CreateTags call.

Additionally this sets up launch templates to use their lt- ID prefix so that we can get/set their tags more easily (now that #9519 is merged).

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 8, 2020
@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 8, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rifelpet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added area/provider/aws Issues or PRs related to aws provider approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 8, 2020
@rifelpet rifelpet force-pushed the cloudmock-cleanup branch from 2f08aab to b1e7704 Compare July 8, 2020 13:53
@rifelpet rifelpet marked this pull request as ready for review July 8, 2020 14:01
@rifelpet rifelpet changed the title WIP Cloudmock cleanup - preparation for EC2 tag-on-create Cloudmock cleanup - preparation for EC2 tag-on-create Jul 8, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 8, 2020
@johngmyers
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 8, 2020
@k8s-ci-robot k8s-ci-robot merged commit 856d581 into kubernetes:master Jul 8, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Jul 8, 2020
@rifelpet rifelpet deleted the cloudmock-cleanup branch October 29, 2020 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/aws Issues or PRs related to aws provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants