-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cloudmock cleanup - preparation for EC2 tag-on-create #9520
Conversation
Skipping CI for Draft Pull Request. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rifelpet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
2f08aab
to
b1e7704
Compare
/lgtm |
In order to add "tag-on-create" support for ec2 resources, cloudmock first needs to support recognizing and storing tags provided in
ec2.Create*
requests. This way aDescribeTags
call will return the tags provided either by the resource'sCreate
call or in aCreateTags
call.Additionally this sets up launch templates to use their
lt-
ID prefix so that we can get/set their tags more easily (now that #9519 is merged).