Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CoreDNS to v1.7.0 - Take 2 #9541

Merged
merged 2 commits into from
Jul 9, 2020

Conversation

rifelpet
Copy link
Member

@rifelpet rifelpet commented Jul 9, 2020

I cherry-picked the commits from #9508 into a new branch to see if this helps with the github action verify failure. I can't reproduce the test failure locally so we should figure out why its happening before merging.

We'll see if this one fails as well.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 9, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rifelpet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added area/addons approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 9, 2020
@hakman
Copy link
Member

hakman commented Jul 9, 2020

Looks like it's ok.

@rifelpet
Copy link
Member Author

rifelpet commented Jul 9, 2020

In the Run actions/checkout@v2 step of the failing job: https://github.com/kubernetes/kops/pull/9508/checks I see it references a merge commit that isn't in the PR, so maybe that's related?

Checking out the ref
/usr/bin/git log -1
commit 5e3a5709c21f906510e2fc673a96c46d5843a6f3
Author: Sandeep Rajan <[email protected]>
Date:   Wed Jul 8 19:56:51 2020 +0200

    Merge 084f586bf1b3589f7a516303df269ea24a9a6cc9 into 98ed5d4fa1a1cd1e2645c26dfd0f443b3aa2375c

Regardless, i think this PR is safe to merge. Thanks @rajansandeep !

@hakman
Copy link
Member

hakman commented Jul 9, 2020

/lgtm
/retest

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 9, 2020
@k8s-ci-robot k8s-ci-robot merged commit 60993a4 into kubernetes:master Jul 9, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Jul 9, 2020
@rifelpet rifelpet deleted the coredns-170 branch October 29, 2020 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/addons cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants